Feature #133
closed[EC-CR-1270] put those lapsed VIP into exception report
100%
Description
The first part of the CR is already implemented in #132.
The second part of the CR is to put those lapsed VIP (who earned DP) into the exception report:- those requirement mentioned in the issue 118 have to be remained
- the reason message for those lapsed VIP (who earned DP) is, Lapse Status in profit_month
- where profit_month is the profit month of the report
This change should take effect on next profit month, which could be on 24-Jan.
Files
Updated by chin-yeh almost 13 years ago
- DP_PROFIT_
MMyyyy
.txt - DP_PROFIT_FINANCE_REFERENCE_
MMyyyy
.xls - DP_PROFIT_EXCEPTION_
MMyyyy
.xls
those files will be used to verify against the actual generated files.
Updated by Chee-Hoong almost 13 years ago
- File DP_PROFIT_102011.txt DP_PROFIT_102011.txt added
here is the report generated.
including new request (VIP lapsed staus in exception report)
Updated by Chee-Hoong almost 13 years ago
Updated by Chee-Hoong almost 13 years ago
Updated by chin-yeh almost 13 years ago
the format of the reason message for lapsed VIP who have earned DP is:
Lapse Status in profit_month
where profit_month is the profit month of the report
Updated by chin-yeh almost 13 years ago
use the value in the data_month column (vip_network table), e.g.:
Lapse Status in yyyy-MM-dd
Lapse Status in 2011-11-30
Updated by Chee-Hoong almost 13 years ago
here is the yyyy-MM-dd format report
Updated by Chee-Hoong almost 13 years ago
Updated by Chee-Hoong almost 13 years ago
- File DP_PROFIT_102011.txt DP_PROFIT_102011.txt added
Updated by chin-yeh almost 13 years ago
- first set (contains bug)
- DP_PROFIT_MMyyyy.txt
- DP_PROFIT_FINANCE_REFERENCE_MMyyyy.xls
- DP_PROFIT_EXCEPTION_MMyyyy.csv
- second set (bug fixed)
- DP_PROFIT_MMyyyy.txt
- DP_PROFIT_FINANCE_REFERENCE_MMyyyy.xls
- DP_PROFIT_EXCEPTION_MMyyyy.csv
The above files must be generated using the batch program.
After reviewed the latest commit codes, please rectify the following items:- close all database resources, e.g. prepared statement, result set
- close all opened streams, e.g. input stream
Updated by Chee-Hoong almost 13 years ago
all files and db resources is properly closed. code changes is commited.
veryfing the generated report now
Updated by chin-yeh almost 13 years ago
Chee-Hoong wrote:
all files and db resources is properly closed. code changes is commited.
veryfing the generated report now
Every stream object, which have been opened have to be closed even it is properties file. please check again.
Updated by Chee-Hoong almost 13 years ago
the code is just commited again.
only found 1 filewriter object that not been closed in writeLog() method.
no idea for files and properties object in setConfigParamateres() method.
Updated by chin-yeh almost 13 years ago
How about this?:
p.load(new FileInputStream(myFile));
To trace this kind of problem, just check what IO packages the program is using.
BTW, are the sets of files that I mentioned earlier ready? Just compress all of them into one file and upload it here.
Also, please update the due date of this issue. This is the date you must get this patch deployed to production environment. To catch up the deadline, try not to do any micro-refactoring on the program.
Updated by Chee-Hoong almost 13 years ago
The programm will be deploy within this week & latest by friday.
here is the attached zip folder
the first set (contains bug) attached with "DPold.rar"
second set (bug fixed attached with "DP.rar"
Updated by Chee-Hoong almost 13 years ago
can i just instantiate a new object and close it?
the object will be the arg for p.load(<inputStreamObject>) as well.
Updated by chin-yeh almost 13 years ago
- Due date changed from 01/09/2012 to 01/13/2012
Google the basic of Java IO:
Chee-Hoong wrote:
can i just instantiate a new object and close it?
the object will be the arg for p.load(<inputStreamObject>) as well.
I set the due date to 13-Jan and inform me at least 1-day in advance before deployment for code review purpose.
Updated by Chee-Hoong almost 13 years ago
if not more required changes the program is ready to be deployed
Updated by chin-yeh almost 13 years ago
- Status changed from New to Feedback
Go ahead.
After deployed, just give us the list of file(s) you have deployed and the deployed date.
Updated by Chee-Hoong almost 13 years ago
the file GenDirectProfit.class is uploaded on 12/1/2012 11:10 am
Updated by chin-yeh almost 13 years ago
Chee-Hoong wrote:
the file GenDirectProfit.class is uploaded on 12/1/2012 11:10 am
Based on the commit history, this is not the only file you have modified. Please check if you've deployed the correct files.
Updated by Chee-Hoong almost 13 years ago
the CurrencyBean.class is deployed to production by 12/01/2012 02:15 pm
Updated by chin-yeh almost 13 years ago
- % Done changed from 0 to 100
Once those files have been generated in production, get someone (if I'm not around) to download it for you and then upload it here.
Updated by Chee-Hoong almost 13 years ago
- File DP_PROFIT_122011.txt DP_PROFIT_122011.txt added
as requested, generated reports are attached here
Updated by Chee-Hoong almost 13 years ago
Updated by Chee-Hoong almost 13 years ago
Updated by chin-yeh almost 13 years ago
- Status changed from Feedback to Closed
- Resolution set to Fixed
verified